Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engines): support simple row desc message #233

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 10, 2024

related: sfackler/rust-postgres@6cd4652, sfackler/rust-postgres#1144, the upstream commit breaks semver (?)

close #232

  • add support for the row description message. in the simple engine, we just ignore it.
  • add a test case with Postgres simple wire protocol
  • also bump dependencies

@skyzh
Copy link
Member Author

skyzh commented Nov 10, 2024

actually, does the original sqllogictest checks against table headers? we can probably do that in the future given that we now have that piece of information.

Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh force-pushed the skyzh/support-row-msg branch from bdad08d to a65c440 Compare November 10, 2024 20:39
@skyzh skyzh merged commit 18cd121 into main Nov 11, 2024
4 checks passed
@skyzh skyzh deleted the skyzh/support-row-msg branch November 11, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic at unreachable if it's not installed with --locked
2 participants